Skip to content

Adjust splom test to run smoothly on the CircleCI #5627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2021
Merged

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 4, 2021

0864381 Fixes the following error resulting in webgl-jasmine failures.

https://app.circleci.com/pipelines/github/plotly/plotly.js/3664/workflows/4b3e322b-fa05-4e0d-86c6-535bd400d538/jobs/110861
splom-test

Also after 051e906 now we run more splom test on the CircleCI.

parcoords tests are also flaky in webgl container; but we 'll address that issue in a separate PR.

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone May 4, 2021
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 29d8d9b into master May 4, 2021
@archmoj archmoj deleted the fixup-splom-test branch May 4, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants