using a more recent nodejs v12 and Chrome verisions on the CircleCI #5604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- higher versions do not pass
|
Why do the tests fail with higher versions? |
Good question. |
|
Seems like our tests are a little too exacting ... we're talking about a 1e-5 change here, totally imperceptible :) |
|
Right, if these test failures are all just rounding errors let's loosen the tests and upgrade to the latest node. |
archmoj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of node.js used on CircleCI is set to
v12.13.0.The most recent node v12 is at
v12.22.1.Browsers used in jasmine tests:
Before: Chrome 78.0.3904.108
After: Chrome 90.0.4430.72
Before: Firefox 70.0
After Firefox 87.0
@plotly/plotly_js