Skip to content

Should set opacity to 1 to be visible #5583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 8, 2021

Addressing obvious bug.
See https://github.com/plotly/plotly.js/pull/5550/files#r609763296

cc: @plotly/plotly_js

@alexcjohnson
Copy link
Collaborator

Heh, certainly out of sync with the comment there... but why didn't this show up in any test images?

@archmoj
Copy link
Contributor Author

archmoj commented Apr 8, 2021

Heh, certainly out of sync with the comment there... but why didn't this show up in any test images?

Possibly because the inside tick label image test didn't cover this case.
BTW it caused problems for image test while working on ticklabeloverflow.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - if you can commit to adding an image with ticklabeloverflow that 🔒 this fix, we can merge as is. 💃

@archmoj archmoj merged commit e3b8709 into master Apr 8, 2021
@archmoj archmoj deleted the fixup-opacity-before-hide branch April 8, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants