Seamless subplots #554
Merged
Seamless subplots #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rm unnecessary 'window' - rm commented out line (ne need to attach canvas to window)
- so that the WebGL -> to <image> step can be generalize to custom base plot modules
- rm obsolete '|| scene' condition - merge multiple if-visible into one
|
|
||
| canvasContainer.appendChild(canvas); | ||
| // no need to attach canvas container to DOM |
There was a problem hiding this comment.
Probably can ⚡ the comment.
Also, do we even the canvasContainer? Can't we just use the canvas element directly? Not 🚫 but it's always nice to remove code.
|
Up to you on the 💃 whenever you're happy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdtusz
This PR continues on #491 and comes in preparation for our mapbox-gl integration.
This PR creates an interface for subplot-specific steps during to-svg and supply-defaults such that
Plotly.plotandPlotly.toImageare agnostic to which subplot types are registered.Important commits
gl3d,gl2d,geoto-svg routines are moved to their correspondingbasePlotModule.trace.scenefor gl3d subplots,trace.geofor geo subplots) are coerced by looping over the registered subplot types - replacing the slew of hard codedcoerce('scene') ...statements.