-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Custom bundle script details #5527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9fe3255
improve partial bundle script
archmoj ca4d557
fixup defaults
archmoj ba00b93
dev-install exorcist v1.0.1
archmoj cbb431e
externalize the source map file
archmoj 5aa2234
drop sourcemap and unminified options
archmoj 7de7be9
remove keepIndex option and keep index in lib for sourcemap
archmoj df8005a
fixup including calendars and transforms in extra bundles
archmoj efa9357
do not expose calendars option for now - unti one could safely drop them
archmoj 9ca5d44
centralize function to create transforms and traces lists
archmoj 9d34652
fixup debug X sourcemap intersect
archmoj 0869970
filter filenames when creating traces and transforms lists
archmoj 7d0145a
make only minified with sourcemap
archmoj fa35c86
drop unused require
archmoj 65efc42
centralize function to test filenames with lowercase
archmoj b05beef
pass extra options to uglify for sourcemap
archmoj fc25200
point to bundle
archmoj bcb7967
improve config
archmoj 9411d7f
put derequire back
archmoj 1e21747
uninstall exorcist v1.0.1 until there prototype pollution is fixed
archmoj 34c09c3
drop sourcemap option
archmoj 6974914
add unminified option
archmoj 4b0f1da
delete index-custom after bundle
archmoj 90bf969
update comment
archmoj 3693985
add a comma to end of calendars require so that it could be easily dr…
archmoj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid name conflicts (let's say one uses e.g.
basic
in output name with different traces), wondering instead ofplotly-*
shouldn't we useplotly_*
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand folks making custom bundles will likely be used to our partial bundles already, so may be tripped up by the switch from
-
to_
. Let's keep-
, these bundles won't be published anyway.