Skip to content

Reinstall karma v5.2.3 to bump socket.io at v2.4.1 #5427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

Reinstall karma v5.2.3 to bump socket.io at v2.4.1 #5427

merged 1 commit into from
Jan 21, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 20, 2021

@archmoj archmoj added this to the NEXT milestone Jan 20, 2021
@archmoj
Copy link
Contributor Author

archmoj commented Jan 21, 2021

The failing publish test is not related to this PR.
So we should be good to merge this.

alexcjohnson
alexcjohnson approved these changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 6191e66 into master Jan 21, 2021
@archmoj archmoj deleted the socket.io-v2.4.1 branch January 21, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson