Bar: fix issue #372 - bar widths with nonnumeric sizes #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great. As mentioned in #539, your patch also fixes a very old bug that made it through our image test mocks. Before merging this PR, you'll have to update the To do so, (1) go to https://circleci.com/gh/plotly/plotly.js/1457 and click on the Artifact tab:
(2) navigate to the
(3) download the |
|
Whoops, missed you're comment in #539. The only tabs visible on circleci were "Test Summary", "circle.yml", and "Build Timing" so I generated the png following the directions in the test/image/README.md. |
|
I had the same problem and I noticed that you need to log into CircleCI for the Artifacts tab to be visible.
|
|
@seibs Thanks! You get my vote for PR of the week 🏆 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for seibs#1
Fixes issue #372
Bars were being filtered out too soon when they had a non-numeric size. This change leaves them in so the bar width/placement calculations take them into account, and leaves filtering them out to the logic already in src/traces/bar/plot.js.