Skip to content

new testbed docker image #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2016
Merged

new testbed docker image #532

merged 4 commits into from
May 18, 2016

Conversation

perigee
Copy link
Contributor

@perigee perigee commented May 13, 2016

This is a part of issue https://github.com/plotly/streambed/issues/6226

  1. add copying index.html file to remove MathJ font warning
  2. remove no need ssh port expose
  3. using candidate for this branch testing on circleci.

The new image version will be 1.1.0

@etpinard @mdtusz

@mdtusz
Copy link
Contributor

mdtusz commented May 13, 2016

Change the max-retries to something a bit greater than 8 (seems to work on the 9th try for me, so maybe 10?) And it's got my 💃

I'll finally be able to test images!

@perigee
Copy link
Contributor Author

perigee commented May 13, 2016

@mdtusz in case the nw fails in the middle of your image testing, then change retries to 10 will have no affect. :(

@perigee perigee changed the title clean new line new testbed docker image May 13, 2016
@mdtusz
Copy link
Contributor

mdtusz commented May 13, 2016

@perigee - with 8 retries, it always fails because the server takes so long to start on my machine. Setting the retries to 10 allows for it to connect and all the tests will run.

@mdtusz
Copy link
Contributor

mdtusz commented May 16, 2016

💃 from me. Will be great to get some image testing done locally 🎉

@etpinard
Copy link
Contributor

💃 once you switched back those candidate tags for latest

@perigee perigee merged commit d3b3513 into master May 18, 2016
@perigee perigee deleted the jun_candidate branch May 18, 2016 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants