-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
FI-51 contour plot fill #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a8b2a13
to
db69c88
Compare
db69c88
to
9d7bbfb
Compare
|
||
// pass on fill information | ||
if(fullTrace.contours.coloring === 'fill') { | ||
colorOptions = convertColorscale(fullTrace, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the boolean fill
option here, as convertColorscale
is only used in this file. But @monfera, I hope you agree that convertColorscale(fullTrace, { fill: true });
would have been cleaner and more robust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etpinard Glad to make this small change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for now. 👍
Great. This is a solid patch for |
Changes:
Related to contourgl fill:
gl-vis/gl-contour2d
plotly.js
gl-contour2d
1.1.2convert.js
for the color fill setupRelated to preparation for contourgl fill work:
gl_plot_interact_basic_test
usingPlotly.purge
(residual todo item from the already merged FI-30)Planned or possible follow-up PRs once the
gl-contour2d
tessellation issue is solved (post the current v1.1.2):gl-contour2d
version inpackage.json
contourgl
fill / line (now it would 'lock in' problematic artifacts)contour
e.g. line thickness/colorgl-contour2d
doesn't handle curves/splines, and the SVG code isn't directly reusable because the SVG implementation properly relies on splines achievable with thepath
mini-language of thed
attributeconvert
and the non-GLcontour