Fix issue where styles weren't reset when re-using SVGs in colorbar

[anaplian]

Fixes #5161

[archmoj]

Good catch!
Before vs After.

[archmoj]

@anaplian to lock this issue, would you please add a test possibly to the end of this block?

plotly.js/test/jasmine/tests/colorbar_test.js

Line 74 in 7f6650b

describe('drawing & editing', function() {

To run the colorbar test locally you could simply use

npm run test-jasmine -- colorbar

Thanks!

[anaplian]

@archmoj Thanks! I have added a test. Let me know what you think 😄

[archmoj]

The test looks great.
Non-blocking, but maybe you could add a getter function to avoid duplication:
Something like:

function pushItemsTo(a) {
    var colorbars = d3.select(gd).selectAll('.colorbar');
    colorbars.selectAll('.cbfill').each(function() {
        var attrsForElem = {};
        for(var i = 0; i < this.attributes.length; i++) {
            var attr = this.attributes.item(i);
            attrsForElem[attr.name] = attr.value;
        }
        a.push(attrsForElem);
    });
}

Plotly.newPlot(gd, [{type: 'contour', z: z}])
.then(function() {
    pushItemsTo(expectedAttrs);

    return Plotly.newPlot(gd, [{type: 'heatmap', z: z}])
    .then(function() {
        return Plotly.react(gd, [{type: 'contour', z: z}]);
    });
})
.then(function() {
    pushItemsTo(actualAttrs);

    expect(actualAttrs).toEqual(expectedAttrs);
})

[anaplian]

Done 🙂

[archmoj]

Nicely done!
Thanks very much @anaplian 🥇
💃