Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cluster features to scattermapbox trace #5147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster features to scattermapbox trace #5147
Changes from 30 commits
01115cd
8e64281
fb67c82
aad34f1
03ea08d
b5caa8f
f1c0e31
1977f12
837761c
ff0b32e
b73d395
0224fa0
d218bab
b800a65
f6d8c39
560405c
4697f9c
dbc5232
07b934b
96d7511
688438c
e02deaf
4b5bfcc
08aa300
1198e56
99a2015
6fdf559
4e09ad3
d75c018
24530b2
c638fd6
89666f8
15c4fa0
c09fe29
807de62
e62219a
d31244a
894a2eb
fcb9800
5cd1157
1715133
6b234f1
9b38fa2
13ce0f0
11df3f6
a232c90
52d6e67
98dfdb8
94f685f
435945b
0d1db3f
0f5e491
82fbdcd
e240ce6
b95a0a5
a51b91f
4054735
a382098
4da7e58
3ea0bb7
c7a23b4
a9d9140
ee2d648
fa07cc5
9e63c04
7a6fd0f
c5ff836
1f42ee2
4b083e1
f3c03cd
23b4d3c
84ede31
4b1bf62
d3b548f
4e1fd5f
76afc6c
0117b41
4980e24
88b24f6
42aabe1
b2eed52
8cc496c
1dee019
02b6f79
805d97b
127f171
12a57c9
34845ec
29e772d
28a9178
a2f34c9
9fe42b6
d76a304
5681a34
e94ef47
9cc0a15
95a81fc
4afc441
c262d4b
74f594d
5ca95d3
8a34a95
13acf8a
22e9519
95751cb
ab37122
52b5051
0a21710
aa6f442
ba58472
b1632b7
6a0ecd2
d9f4641
b707c0f
bb70db7
0f5c33c
6d291c9
1de111d
f78b46e
aaf33d3
f7baf5d
432e448
e840f8f
2361958
91ea2f6
47c5773
591b321
bd379f8
05893b3
b5f09fb
6e80dc9
21b59e4
e01dc32
b46327c
aa57518
fe912ae
70e708a
fa0f3b2
26eb86a
c87cda6
c59fcd9
d2c656d
d7423af
cfd8e36
2217f7c
60addca
a83d5af
01efcf5
5244a09
a7518ec
8efa7bd
2ff6cfb
2108c8d
a1d021b
6f575a3
0403aa7
3b9071f
8796f1b
648c3c9
0cf2a7f
fb8d995
fbaf868
3a5ca3a
189243f
0b2397a
fe5ee9b
b97895f
cdd836c
24c7699
0f0ca1f
2470532
7895727
4d98780
a19b05b
8ebfa71
db00dea
d4eadbd
e351d9b
632532f
6d87753
5700db2
0e52adb
999f877
7b22175
445eee4
5f252f5
90c3097
40c09b7
08f3f04
7527d55
4492a37
8c7a526
fa781ed
4a5a92c
7b1d507
54be4ae
7f1e699
18eca7d
fbc5666
ee836ff
677f7c8
f07cae9
705468b
e786754
d00475a
0a345e3
0cbb4b5
75c1c39
43c219c
0bc0328
752060a
6e83a1c
5016156
43bb8f0
85b727f
b16a694
4939d3b
0e61ce1
1faa5b7
c5d67b6
95aedef
eb799bc
4a37e2c
97b8472
f889df1
ed639f4
c902830
0fe6ba2
de1dc20
c2f1ed4
26e7791
2ae0f1b
d23c597
9fc6f3c
69d1589
b03a18b
22abfa8
da9e6ec
68eea5c
c6cfa77
ba7e38f
ae93bf5
3b1f0da
9d82a40
6faf7b3
aeb2d7c
4c9eaeb
6a3ce4f
e1236a2
f536972
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused about what this attribute does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cluster can be coloured in different colors and take different sizes dependent on how many observations that are contained in a cluster. The steps determines when the cluster will change size or/and color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice any changes when trying to tweak this parameter.
@elben10 wondering if you could provide an illustration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @elben10 please provide part of this info in the attribute description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we could drop
color
andsize
here and reusetrace.marker.color
andtrace.marker.size
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can drop
color
andsize
. Shouldn't one be able to have different color and sized point and clusters. If we use the color fromtrace.marker.color
it will no be possible to have a cluster with say 3 different colors, and the points being pained with another color.Like this example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead of having color and size both be arrays, we might want to have a single attribute that accepts an array of color/size tuples like
steps: [ {color: "red", size: 10} ]
or something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we need either
color
/size
to be a singular value or an array. Ifcolor
/size
is an array, steps should also be defined as an array that has length one less thancolor
/size
.steps
defines at which levels the cluster changescolor
/size
dependent on how many observations the cluster contains.One way to achieve that would be
steps: [ {color: "red", size: 10, "step": null}, {color: "blue", size: 20, "step": 20} ]
In this case, the cluster will be coloured red and sized 10 as long as there are less than 20 observations in the cluster else the cluster will be coloured blue and sized 20.