-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Improve contribution guide & readme, add code of conduct #5068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b733954
Explanation of how changes get made
nicolaskruchten 6df7dff
Apply suggestions from code review
nicolaskruchten 63fb73f
PR feedback
nicolaskruchten 5f39303
Update CONTRIBUTING.md
nicolaskruchten 7a402a3
Update CONTRIBUTING.md
nicolaskruchten 3d931e2
Update CONTRIBUTING.md
nicolaskruchten 594aeb2
Create CODE_OF_CONDUCT.md
nicolaskruchten 58f1123
Update CONTRIBUTING.md
nicolaskruchten f9aec7d
Update CODE_OF_CONDUCT.md
nicolaskruchten 96d1616
Update CONTRIBUTING.md
nicolaskruchten 8fb8d80
Rename CODE_OF_CONDUCT.md to code_of_conduct.md
nicolaskruchten 32e374d
Update CONTRIBUTING.md
nicolaskruchten 518d2ea
Update README.md
nicolaskruchten 01dd22b
Update CONTRIBUTING.md
nicolaskruchten 5c73c7c
Update README.md
nicolaskruchten e367692
Update README.md
nicolaskruchten f69d47d
Update code_of_conduct.md
nicolaskruchten 191c829
Update README.md
nicolaskruchten c22e23b
Update CONTRIBUTING.md
nicolaskruchten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. This is rather confusing. I am sure I should not be listed on top of this list.
Let's maintain the
Hall of Fame
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

@archmoj I think the contributor graphs make it pretty clear that you're the primary maintainer of this project since @etpinard's departure (and arguably on an equal footing to him for some time prior to that). So there should be no question that this placement is deserved. But if you would prefer to install me as a figurehead public face of the project I guess I won't protest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was my reasoning as well, but I'm happy to switch out the top two
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Order switched.