Skip to content

Do not display first tick added by period ticklabelmode #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Aug 7, 2020

Follow up of implementing #4911 by #4993.
This PR fixes a bug with the out of range first tick added for period option of ticklabelmode as illustrated in 03ee429 commit

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Aug 7, 2020
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 💃

@archmoj archmoj merged commit e65fede into master Aug 10, 2020
@archmoj archmoj deleted the dont-show-ticks-before-tick0 branch August 10, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants