Skip to content

Call dragElement.getCursor(), not cursor() #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

coopy
Copy link

@coopy coopy commented May 3, 2016

@etpinard
Copy link
Contributor

etpinard commented May 3, 2016

Great. Thanks for doing this 🍻

It would be nice to a test case before merging this in.

@mdtusz just added an editable: 'true' test for legends here, @coopy would you mind adding a similar test for dragging editable annotations?

@etpinard etpinard added bug something broken status: in progress labels May 3, 2016
@coopy
Copy link
Author

coopy commented May 3, 2016

Sure!
It's worth noting that this does not solve the issue (I think this is a 🐛 ) with the note position updating while the mouse is dragging. It only gets rid of the exception.

kw6kl3ks3s

@mdtusz
Copy link
Contributor

mdtusz commented May 4, 2016

I'll tackle this tomorrow. When we removed the last bits of nested svg, parts of annotation changed. It now uses a transform instead of x/y positioning so just needs a quick update to change that instead.

@mdtusz mdtusz mentioned this pull request May 4, 2016
@coopy
Copy link
Author

coopy commented May 4, 2016

Closing - replaced by #505!

@coopy coopy closed this May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants