Plot Area: Plot clip bug #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The d3 selection was only being created. This has added an update "join" on the selection.
| .append('rect') | ||
| .append('rect'); | ||
|
|
||
| plotClip.selectAll('rect') |
There was a problem hiding this comment.
Nicely done. Man, I gotta got better at noticing these as a reviewer.
There was a problem hiding this comment.
I gotta get better at noticing these as a programmer.
There was a problem hiding this comment.
But really, I think it's just a symptom of the "d3 pattern". It's not explicitly clear and pretty tough to reason about what exactly each selection/block is doing.
There was a problem hiding this comment.
Looks like d3 v4 will make this easier.
Taken from https://medium.com/@mbostock/what-makes-software-good-943557f8a488#.rb39u8abk
|
💃 after adding that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #488. The d3 selection was only being created. This has added an update "join" on
the selection so the clips will be updated whenever relayout is called.