Skip to content

discard ranges for single value parcoords dimensions when drag a new axis range #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 27, 2020

Fix #4876 | before vs after demo.

@plotly/plotly_js

TODO:

  • add jasmine test

@archmoj archmoj added bug something broken status: in progress labels May 27, 2020
@archmoj archmoj changed the title fix 4831 - discard ranges for single value parcoords dimensions when drag a new axis range discard ranges for single value parcoords dimensions when drag a new axis range May 28, 2020
@archmoj archmoj added this to the v1.54.2 milestone Jun 5, 2020
@archmoj archmoj requested review from alexcjohnson and removed request for alexcjohnson June 5, 2020 03:22
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I don't understand how we got [0][0] > [0][1], but this does appear to work 👍
💃

@archmoj archmoj merged commit be70865 into master Jun 8, 2020
@archmoj archmoj deleted the fix4831-parcoords branch June 8, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parcoords - lines disappear, categorical axis with single tick
2 participants