Skip to content

Print error before calling throw #4750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

Print error before calling throw #4750

merged 1 commit into from
Apr 9, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 9, 2020

Logging errors in tasks & tests would make it easier to debug and write new tests.

@plotly/plotly_js

alexcjohnson
alexcjohnson approved these changes Apr 9, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. 💃

@archmoj archmoj merged commit 507308b into master Apr 9, 2020
@archmoj archmoj deleted the log-error-before-throw branch April 9, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson