Skip to content

unified hover label #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Mar 13, 2020
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
18ddd5d
hover: move text logic into function getHoverLabelText()
antoinerg Mar 6, 2020
1c92511
introduce hovermode 'x unified' and 'y unified'
antoinerg Mar 6, 2020
e43b197
unified hoverlabel: add smart defaults for spikelines
antoinerg Mar 6, 2020
2bc9c77
unified hoverlabel: test label's background color
antoinerg Mar 9, 2020
3fe5951
unified hoverlabel: do not display trace name if it's empty
antoinerg Mar 9, 2020
88bb33a
unified hoverlabel: fix positioning for edge cases
antoinerg Mar 9, 2020
07fb8af
unified hoverlabel: test finance trace
antoinerg Mar 9, 2020
a704769
unified hoverlabel: fix for cases when hoverData is empty
antoinerg Mar 9, 2020
9ea8bfd
unified hoverlabel: revert changes to legend/defaults.js
antoinerg Mar 10, 2020
36bc6b5
unified hoverlabel: use stricter comparison operators
antoinerg Mar 10, 2020
e82e010
unified hoverlabel: :hocho: unused mock/baseline
antoinerg Mar 10, 2020
818223d
hover: revert unnecessary modification
antoinerg Mar 10, 2020
4bf9052
unified hoverlabel: title font should be the same as fullLayout.font
antoinerg Mar 10, 2020
609d5ca
unified hoverlabel: do not process MathJax in hover since it's not su…
antoinerg Mar 10, 2020
ec8c373
unified hoverlabel: style legend item using marker's style
antoinerg Mar 10, 2020
0822b93
unified hoverlabel: inherit traceorder from the the legend
antoinerg Mar 11, 2020
ae5b9cc
unified hoverlabel: fix filtering logic
antoinerg Mar 11, 2020
c0e1bf7
unified hoverlabel: fix waterfall symbol
antoinerg Mar 11, 2020
bca4a70
unified hoverlabel: test waterfall symbol
antoinerg Mar 11, 2020
8308111
unified hoverlabel: only apply bar-like styling of symbol to waterfall
antoinerg Mar 11, 2020
33a037b
unified hoverlabel: fix code style
antoinerg Mar 11, 2020
a9c899b
unified hoverlabel: return early if nothing is hovered on
antoinerg Mar 11, 2020
06ad9a7
unified hoverlabel: swap hovermode in orientationaxes block
antoinerg Mar 11, 2020
53c5714
unified hoverlabel: rank points based on trace's index
antoinerg Mar 11, 2020
dd86a60
unified hoverlabel: fix test
antoinerg Mar 11, 2020
a857d71
unified hoverlabel: update description
antoinerg Mar 13, 2020
05188d6
unified hoverlabel: fix description
antoinerg Mar 13, 2020
af4a07c
unified hoverlabel: remove modebar hover buttons when activated
antoinerg Mar 13, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/components/fx/layout_attributes.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,16 @@ module.exports = {
editType: 'modebar',
description: [
'Determines the mode of hover interactions.',
'If `closest`, a single hoverlabel will appear',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put flags between two * and attributes between ` chars.
E.g. this line should be

'If *closest*, a single `hoverlabel` will appear',

'for the closest point within the `hoverdistance`.',
'If `x` (or `y`), multiple hoverlabels will appear for multiple points',
'at the closest `x`- (or `y`-) coordinate within the `hoverdistance`,',
'with the caveat that no more than one hoverlabel will appear per trace.',
'If `x unified` (or `y unified`), a single hoverlabel will appear',
'multiple points at the closest x- (or y-) coordinate within the `hoverdistance`',
'with the caveat that no more than one hoverlabel will appear per trace.',
'In this mode, spikelines are enabled by default perpendicular to the specified axis.',
'If false, hover interactions are disabled.',
'If `clickmode` includes the *select* flag,',
'`hovermode` defaults to *closest*.',
'If `clickmode` lacks the *select* flag,',
Expand Down