-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
unified hover label #4620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
unified hover label #4620
Changes from 22 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
18ddd5d
hover: move text logic into function getHoverLabelText()
antoinerg 1c92511
introduce hovermode 'x unified' and 'y unified'
antoinerg e43b197
unified hoverlabel: add smart defaults for spikelines
antoinerg 2bc9c77
unified hoverlabel: test label's background color
antoinerg 3fe5951
unified hoverlabel: do not display trace name if it's empty
antoinerg 88bb33a
unified hoverlabel: fix positioning for edge cases
antoinerg 07fb8af
unified hoverlabel: test finance trace
antoinerg a704769
unified hoverlabel: fix for cases when hoverData is empty
antoinerg 9ea8bfd
unified hoverlabel: revert changes to legend/defaults.js
antoinerg 36bc6b5
unified hoverlabel: use stricter comparison operators
antoinerg e82e010
unified hoverlabel: :hocho: unused mock/baseline
antoinerg 818223d
hover: revert unnecessary modification
antoinerg 4bf9052
unified hoverlabel: title font should be the same as fullLayout.font
antoinerg 609d5ca
unified hoverlabel: do not process MathJax in hover since it's not su…
antoinerg ec8c373
unified hoverlabel: style legend item using marker's style
antoinerg 0822b93
unified hoverlabel: inherit traceorder from the the legend
antoinerg ae5b9cc
unified hoverlabel: fix filtering logic
antoinerg c0e1bf7
unified hoverlabel: fix waterfall symbol
antoinerg bca4a70
unified hoverlabel: test waterfall symbol
antoinerg 8308111
unified hoverlabel: only apply bar-like styling of symbol to waterfall
antoinerg 33a037b
unified hoverlabel: fix code style
antoinerg a9c899b
unified hoverlabel: return early if nothing is hovered on
antoinerg 06ad9a7
unified hoverlabel: swap hovermode in orientationaxes block
antoinerg 53c5714
unified hoverlabel: rank points based on trace's index
antoinerg dd86a60
unified hoverlabel: fix test
antoinerg a857d71
unified hoverlabel: update description
antoinerg 05188d6
unified hoverlabel: fix description
antoinerg af4a07c
unified hoverlabel: remove modebar hover buttons when activated
antoinerg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antoinerg would you please update the description of
hovermode
in respect to these two new flags?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolaskruchten could you tackle this one (ie. updating the description of
hovermode
to includex unified
andy unified
) ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @nicolaskruchten
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please insert, before the existing paragraph, something like:
If closest, a single hoverlabel will appear for the closest point within the
hoverdistance
.If x (or y), multiple hoverlabels will appear for multiple points at the closest x- (or y-) coordinate within the
hoverdistance
, with the caveat that no more than one hoverlabel will appear per trace.If x unified (or y unified), a single hoverlabel will appear multiple points at the closest x- (or y-) coordinate within the
hoverdistance
, with the caveat that no more than one hoverlabel will appear per trace. In this mode,spikelines
are enabled by default perpendicular to the specified axis.If false, hover interactions are disabled.
Edit to taste and/or to correct inaccuracies :)