Skip to content

Ternary (and scatter) fill #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 22, 2016
Merged

Ternary (and scatter) fill #462

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
aab9536
first cut at fill toself/tonext
alexcjohnson Apr 21, 2016
4df54d7
Revert "remove 'fill' and 'fillcolor' (for now):"
alexcjohnson Apr 21, 2016
3bc66f0
put in the scatterternary fill options I *really* want
alexcjohnson Apr 21, 2016
92b04e1
closed path smoothing for scatter lines
alexcjohnson Apr 22, 2016
9896d81
scatter fill description
alexcjohnson Apr 22, 2016
38af594
image test of new scatter fill modes
alexcjohnson Apr 22, 2016
0865fb5
ternary grid and axis lines on by default
alexcjohnson Apr 22, 2016
0b33f53
description for scatterternary.fill, separate from scatter.fill
alexcjohnson Apr 22, 2016
d68d95e
ternary outer ticks on by default too
alexcjohnson Apr 22, 2016
459ea51
update ternary image tests for new defaults
alexcjohnson Apr 22, 2016
aca5423
ternary fill image test
alexcjohnson Apr 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/traces/scatter/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,29 @@ module.exports = {
role: 'style',
description: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be a good time to add more info the description field.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 added. It takes a lot to describe this behavior...

'Sets the area to fill with a solid color.',
'Use with `fillcolor`.'
'Use with `fillcolor` if not *none*.',
'*tozerox* and *tozeroy* fill to x=0 and y=0 respectively.',
'*tonextx* and *tonexty* fill between the endpoints of this',
'trace and the endpoints of the trace before it, connecting those',
'endpoints with straight lines (to make a stacked area graph);',
'if there is no trace before it, they behave like *tozerox* and',
'*tozeroy*.',
'*toself* connects the endpoints of the trace (or each segment',
'of the trace if it has gaps) into a closed shape.',
'*tonext* fills the space between two traces if one completely',
'encloses the other (eg consecutive contour lines), and behaves like',
'*toself* if there is no trace before it. *tonext* should not be',
'used if one trace does not enclose the other.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic.

].join(' ')
},
fillcolor: {
valType: 'color',
role: 'style',
description: 'Sets the fill color.'
description: [
'Sets the fill color.',
'Defaults to a half-transparent variant of the line color,',
'marker color, or marker line color, whichever is available.'
].join(' ')
},
marker: {
symbol: {
Expand Down