Skip to content

Refactor gl3d scene #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 29, 2020
Merged

Refactor gl3d scene #4360

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1081e6a
no need to duplicate camera on gl-plot3d scene
archmoj Nov 4, 2019
e1b1a39
avoid low level webgl calls from plotly.js gl3d scene
archmoj Nov 4, 2019
0d76fe2
Now with reduced arguments we can make initializeGLPlot and tryCreate…
archmoj Nov 5, 2019
b8ca391
make render another method of Scene object
archmoj Nov 5, 2019
94ebb09
remove unused parameter glplotLayout and glplot.update call
archmoj Nov 5, 2019
d8af1dc
add glOptions so that it is contolled by plotly.js not gl-plot3d
archmoj Nov 5, 2019
9066bd1
fix issue 4236 - do not init dynamic gl with premultipliedAlpha
archmoj Nov 5, 2019
fe17eb9
apply gl-plot3d changes
archmoj Nov 5, 2019
d23fb9b
Merge branch 'master' into revise-gl3d-scene
archmoj Jan 13, 2020
5adf6b6
bump gl-plot3d at 2.4.0
archmoj Jan 13, 2020
ade22a6
set premultipliedAlpha to true as it was applied before
archmoj Jan 28, 2020
ff2ecc7
list is-mobile in package.json - it was already in package-lock
archmoj Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plots/gl3d/scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ proto.tryCreatePlot = function() {
gl: scene.gl,
glOptions: {
preserveDrawingBuffer: isMobile,
premultipliedAlpha: true,
premultipliedAlpha: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Does this lead to any changes in performance ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. It shouldn't. Anyway I would double check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided not to change this config in this PR for now: ade22a6.

antialias: true
},
container: scene.container,
Expand Down