Skip to content

Apply reversed colorscale setting and coloraxis in contour and histogramcontour legends #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Nov 16, 2019

Fixes #4354 and fixes #4355

  • displays identical legends for identical graphs
  • use coloraxis colorscale (if defined) to style legend
  • use baseAttrs instead of plotAttrs in all trace/attributes.js files (refactor commit 0c00efc)

@alexcjohnson
@plotly/plotly_js
cc: @nicolaskruchten

@archmoj archmoj added bug something broken status: reviewable labels Nov 16, 2019
@archmoj archmoj changed the title Apply reversed colorscale setting in contour and histogramcontour legends Apply reversed colorscale setting and coloraxis in contour and histogramcontour legends Nov 16, 2019
@etpinard
Copy link
Contributor

💃 nicely done @archmoj (once that flaky test passes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
2 participants