-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Handle missing vertexcolor and facecolor in mesh3d #4353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rename missing vertex color reverts to white, but missing face color is omitted. Is that intentional / desirable? Offhand I'd think we'd want the faces to be white as well. Or perhaps a light gray in both cases... |
We could use gray color for both cases which is pretty easy to do. |
In general I feel like data should not disappear if some secondary characteristic of it (color in this case, but more generally anything beyond its position) is missing or invalid. For example scatter traces with a short This is mostly useful for debugging, so you can see what parts you got right and what parts have issues. If your goal is to make a transparent face, you should specify this explicitly rather than relying on an implicit "bad data becomes transparent" |
- display mesh3d missing colors gray - update baseline
@alexcjohnson Good call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
Fix #4348 & #4349
gl-mesh3d
used to stop when encountering a missingvertexcolor
orfacecolor
which is fixed bygl-mesh3d
v2.1.2 and v2.1.3 patches.This PR bumps
gl-mesh3d
and adds an image test.@plotly/plotly_js