Skip to content

Use Node v12.13.0 (LTS) for development #4322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 21, 2019
Merged

Use Node v12.13.0 (LTS) for development #4322

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b18bf72
use node 12.13.0 (LTS) on CircleCI
etpinard Oct 30, 2019
dff2d0b
use node "12" on AppVeyor
etpinard Oct 30, 2019
39c1944
update Contributing to mention node v12
etpinard Oct 30, 2019
a5eba61
set --node 12.13 and --npm 6.12 in `check-node-version` call
etpinard Oct 30, 2019
7759c76
bump npm version check to `6.13`
etpinard Nov 20, 2019
205f4f8
Merge branch 'master' into use-node12
etpinard Nov 20, 2019
97fe760
adapt "replot canvas" test for Chrome 78
etpinard Nov 20, 2019
cb5be64
add @flaky to editable:true colorbar tests
etpinard Nov 20, 2019
9ec38b1
round bbox widths values to workaround Chrome78 rounding errors
etpinard Nov 20, 2019
00b7d30
tweak hover label px position in scatterternay fill test
etpinard Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ version: 2.0
jobs:
build:
docker:
- image: circleci/node:10.9.0
- image: circleci/node:12.13.0
working_directory: ~/plotly.js
steps:
- checkout
Expand Down Expand Up @@ -39,7 +39,7 @@ jobs:
test-jasmine:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:10.9.0-browsers
- image: circleci/node:12.13.0-browsers
parallelism: 2
working_directory: ~/plotly.js
steps:
Expand All @@ -52,7 +52,7 @@ jobs:
test-jasmine2:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:10.9.0-browsers
- image: circleci/node:12.13.0-browsers
parallelism: 3
working_directory: ~/plotly.js
steps:
Expand All @@ -65,7 +65,7 @@ jobs:
test-jasmine3:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:10.9.0-browsers
- image: circleci/node:12.13.0-browsers
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:

test-syntax:
docker:
- image: circleci/node:10.9.0
- image: circleci/node:12.13.0
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand All @@ -127,7 +127,7 @@ jobs:
test-bundle:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:10.9.0-browsers
- image: circleci/node:12.13.0-browsers
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand All @@ -138,7 +138,7 @@ jobs:

publish:
docker:
- image: circleci/node:10.9.0
- image: circleci/node:12.13.0
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand Down
10 changes: 4 additions & 6 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,10 @@ We use the following [labels](https://github.com/plotly/plotly.js/labels) to tra
#### Prerequisites

- git
- [node.js](https://nodejs.org/en/). We recommend using node.js v10.x, but all
versions starting from v6 should work. Upgrading and managing node versions
can be easily done using [`nvm`](https://github.com/creationix/nvm) or its
Windows alternatives.
- [`npm`](https://www.npmjs.com/) v6.x and up (which ships by default with
node.js v10.x) to ensure that the
- [node.js](https://nodejs.org/en/). We recommend using node.js v12.x (LTS).
Upgrading and managing node versions can be easily done using
[`nvm`](https://github.com/creationix/nvm) or its Windows alternatives.
- [`npm`](https://www.npmjs.com/) v6.x and up to ensure that the
[`package-lock.json`](https://docs.npmjs.com/files/package-lock.json) file is
used and updated correctly.

Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
environment:
nodejs_version: "10"
nodejs_version: "12"

install:
- ps: Install-Product node $env:nodejs_version
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"start-image_viewer": "node devtools/image_viewer/server.js",
"start": "npm run start-test_dashboard",
"baseline": "node tasks/baseline.js",
"preversion": "check-node-version --node 10 --npm 6 && npm-link-check && npm ls --prod",
"preversion": "check-node-version --node 12.13 --npm 6.12.0 && npm-link-check && npm ls --prod",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@archmoj I chose slightly more strict version checks this time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now requesting for npm 6.13.x 7759c76

"version": "npm run build && git add -A dist src build",
"postversion": "node -e \"console.log('Version bumped and committed. If ok, run: git push && git push --tags')\"",
"postpublish": "node tasks/sync_packages.js",
Expand Down