Flaky image tests #4321
Merged
Flaky image tests #4321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
commented
Oct 30, 2019
| exit $EXIT_STATE | ||
| ;; | ||
|
|
||
| image2) | ||
| retry npm run test-image -- --just-flaky |
There was a problem hiding this comment.
We probably don't even need to run this in a retry loop, but I thought might as well do this.
Let me know if you think 🔪 that retry would be a better idea.
|
For further investigation:
|
|
@etpinard thanks very much for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run test-imagehas been very flaky on CI during the last week or so.This PR adds a way to flag "flaky" mocks in
compare_pixels_test.js. These flaky mocks are skipped on CI in the (main)image)container and they are run in isolating in theimage2)container alongsidenpm run test-export.This is not a perfect solution by any means, but I hope this will help keep @plotly/plotly_js devs productive until we find a better solution.