Skip to content

Enable second try to create gl3d scenes for Chrome 77 webgl bug #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2019
Merged

Enable second try to create gl3d scenes for Chrome 77 webgl bug #4256

merged 1 commit into from
Oct 7, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 6, 2019

Addresses #4233.
The very first try to create a 3-D scene in Chrome 77 is not successful.
This patch enables the second attempt to create gl3d scene in case the first try was not successful.
@etpinard

@archmoj archmoj added bug something broken status: reviewable labels Oct 6, 2019
@archmoj archmoj added this to the v1.50.0 milestone Oct 6, 2019
@etpinard
Copy link
Contributor

etpinard commented Oct 7, 2019

Thanks @archmoj 💃

Let's merge this in, but let's keep #4233 open until we found a better solution.

@archmoj archmoj merged commit 713b42a into master Oct 7, 2019
@archmoj archmoj deleted the gl3d-chrome-77 branch October 7, 2019 13:31
@etpinard etpinard mentioned this pull request Oct 7, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 4, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v1.50.0
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @etpinard