Skip to content

Revise the output of bar text transform functions #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2019
Merged

Revise the output of bar text transform functions #4081

merged 2 commits into from
Jul 26, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 26, 2019

This PR makes bar transform text functions useful for transitions and on par with pie versions.
Having an object instead of string in the result, one could read properties such as scale and work with them as needed in transitions of treemap traces.

@plotly/plotly_js

@etpinard
Copy link
Contributor

Ok, looks good to me 💃

@archmoj archmoj merged commit 38cd9e2 into master Jul 26, 2019
@archmoj archmoj deleted the make-bar-text-transform-reusable-for-transitions branch July 26, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @etpinard