Rangeslider style on select fix #4022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- which is a more centralised DRY place - use nodeRangePlot3 for range-plot trace, that way we don't override node3 when plotting a trace in a range-plot
- to improve selection perf.
... for modules that define a _module.styleOnSelect method
- as they're only meant to be used on select!
... during selection mousemove. To do so, - make _module.styleOnSelect handle a 3rd argument (in practice, a d3 selection of <g.trace> of the main plot OR the range plot) - similarly for _module.style methods that get called during selections - N.B. has to "fix" one (wrong) finance select assertion
|
Pinging @mbkupfer who seems to be very good at noticing rangeslider/selection bugs Could you try https://codepen.io/etpinard/pen/KjxWzZ - if you get the chance? Thanks very much! |
|
Looking good to my eyes. |
Yeah, that would be nice. |
|
Excellent. I tried to test out many different scenarios including click events and multiple series and didn't see any sync problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@plotly/plotly_js - tweaking a few things in selection / rangeslider land.
fixes #3957
before: https://codepen.io/mbkupfer/pen/zVGwoZ
after: https://codepen.io/etpinard/pen/KjxWzZ (try selecting the bars)