indicator: position delta using drawing.bBox #4007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Jul 2, 2019
etpinard
reviewed
Jul 2, 2019
etpinard
reviewed
Jul 2, 2019
| @@ -0,0 +1,140 @@ | |||
| { | |||
| "data": [{ | |||
There was a problem hiding this comment.
Nice mock!
For reference, on master this mock looks like
There was a problem hiding this comment.
It looks fine on master but if you change the font-size of delta or number, the alignment might break.
|
Looks good @antoinerg - thanks for the quick turnaround 💃 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because guessing the size of the text to vertically align it wasn't robust enough.
I introduced a new mock
indicator_datacard3to showcase the 12 possible combinations ofdelta.positionandalign. Changing the font size of eithernumberordeltanow always yield a correct alignment.Codepen: https://codepen.io/antoinerg/pen/qzYpeV