More consistent geo maps configs #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- required to make the dblclick handler work in the latest d3 - more info: d3/d3#1985
- use sane-topojson to grab topojson deps
| setBackground: defaultSetBackground, | ||
|
|
||
| // URL to topojson files used in geo charts | ||
| topojsonURL: 'https://cdn.plot.ly/' |
This reverts commit 94a450c.
- so that temporary dev build are ignored by git. - `npm run build` is reserved for dist/ builds, while `npm run watch` and `npm run start-test_dashboard` use the build/ plotly.js
etpinard
added a commit
that referenced
this pull request
Nov 16, 2015
More consistent geo maps configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexcjohnson @bpostlethwaite @cldougl
This PR:
d3version. This is related to this change Double-click with d3.behavior.zoom should use an animated transition. d3/d3#1985 in the geo map double click handler.PLOTLYENV.TOPOJSON_URLglobal setting is replaced by a config argument with default pointing to the CDN.