Skip to content

ensure that tester property of drawing object exists #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wryczko
Copy link

@wryczko wryczko commented Jun 18, 2019

When I tried to customize modeBarButtons by using imported objects (import PlotlyButtons from 'plotly.js/src/components/modebar/buttons') I got following error:

TypeError: Cannot read property 'node' of undefined at Object.push../node_modules/plotly.js/src/components/drawing/index.js.drawing.bBox (index.js:926)

I've noticed this issue was once explained here #3106, but no actions have been taken. I can confirm, that this issue exists, but I have reproduced it differently.

@etpinard
Copy link
Contributor

Thanks very much for the PR!

Before we start thinking about merging it, could you please share a reproducible example of the bug you're trying to fix? I understand that your issue appears similar to #3106, but we haven't been able to reproduce that one (yet). Once you figured out how to replicate the problem, we'll be able to lock your fix down in a test.

Cheers!

@etpinard
Copy link
Contributor

Closing due to lack of activity.

If someone can replicate the problem in a codepen, please open an issue!

Better yet, if someone can write a failing test case and then write a patch fixing it, please open a PR!

@etpinard etpinard closed this Jul 23, 2019
@federicomassa
Copy link

This happened to me and independently found the same way to solve it. The fix works for me, but when I tried to replicate it on CodePen I didn't manage to, the issue just didn't show up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants