-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Refactor parcoords - bug fixes - reuse axes ticktext - support pseudo html labels - features for label angle & position #3966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
archmoj
merged 70 commits into
master
from
refactor-parcoords-bug-fixes-labelangle-side
Jun 27, 2019
Merged
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
b050eec
refactor parcoords - lims > limits
archmoj 57c0abd
refactor parcoords - replace Array.apply with simple fill method
archmoj 321b73a
refactor parcoords - i > i0 - ii > i1
archmoj e7f18af
refactor parcoords - simplify plot sorter function
archmoj e5304b1
refactor parcoords - dim1 > dim0
archmoj dd65f3f
refactor parcoords - dim2 > dim1
archmoj be5df36
refactor parcoords - pass1 - add highp flags - move imports to the to…
archmoj 55a5018
refactor parcoords - remove one more argument to position functions
archmoj 9702db6
refactor parcoords - move axisY funcs to main shaders - remove unused…
archmoj 0c1959c
refactor parcoords - avoid passing complex multi dim mat4 argument be…
archmoj 51c59e8
refactor parcoords - no need to pass resolution to position functions
archmoj 3b01429
refactor parcoords - now no need to pass dims to one axisY functions
archmoj 562973d
refactor parcoords - combine pick and vertex shader programs
archmoj 3516ba5
refactor parcoords - move position code to single location used now i…
archmoj b320638
refactor parcoords - removed many now unused passing arguments
archmoj 48e091e
refactor parcoords - combine two mod functions into one
archmoj f127343
refactor parcoords - remove one more function and adjustment for perf…
archmoj 947dbe7
refactor parcoords - add function to handle hide logic
archmoj fcd4bcb
refactor parcoords - rearrange indices and arguments in makeItem
archmoj ac1ace3
refactor parcoords - lint shaders
archmoj c05683f
refactor parcoords - remove unused variables and optimize within rast…
archmoj 5464b4a
refactor parcoords - change functions from inside to outside
archmoj 5280ce4
refactor parcoords - no need for extra clamping - already between 0 a…
archmoj ea6fbe4
refactor parcoords - simplify code
archmoj 296859f
refactor parcoords - remove non-parametic constants
archmoj e89676a
refactor parcoords - cut long variable names and move item.count twea…
archmoj b326947
no need to offset texture inputs in vertex shader
archmoj 592f56b
refactor parcoords - set color info outside position loop
archmoj b4e285e
bug fix issue 3749 parcoords outside range - add image tests
archmoj 76667c9
refactor parcoords - remove unused colorClamp parameter
archmoj 3a5b4ca
refactor parcoords - add test for 60 dimensions - clean up shader for…
archmoj 286db3b
refactor parcoords - describe panels 1-60 in vertex shaders
archmoj 40de5d9
add image test for parcoords with 256 colors
archmoj 5dfe455
refactor parcoords - use general variable names in plot and base_plot
archmoj 9937208
apply Cartesian axis tickText to format parcoords linear data
archmoj ca79f97
refactor parcoords - rm root unused variable
archmoj 5cccd86
psuedo-html and mathjax formats in parcoords labels - fix for issue 3206
archmoj 4e749bd
refactor parcoords - get rid of one extra dimension, complex indexing…
archmoj ccfc81e
improve test for parcoords with 60 dims
archmoj 90c358d
fix mathjax show on image test
archmoj 178273c
implement labelangle for parcoords
archmoj 73f23de
revise various parcoords editType from calc to plot
archmoj 8f23241
use tickvals and ticktext in new parcoords mock
archmoj b0d3bdd
added jasmine test for parcoords react with editType plot instead of …
archmoj cc580fe
refactor parcoords - use one vertex shader
archmoj 369eb46
optimize for performance - now no need to update palette for every co…
archmoj 213f965
move 3 functions outside line.js main
archmoj 407d72a
refactor parcoords - using isContext and isPick instead of context & …
archmoj ebf57f0
apply per dimension tickformat in linear axes ticktext
archmoj 48860c2
fixup tests to run on CI
archmoj 9cbbcbf
dont touch trace data - move handeling of typedarrays from calc to pl…
archmoj 3a4d428
add parcoords labelside (top|bottom) help display tilted labels with …
archmoj 6aad768
revisit contextColor setup
archmoj 6403347
refactor parcoords - better variable names in parcoords plot
archmoj b5d24e1
refactor parcoords - move nested functions outside plot callbacks
archmoj 1b7c0ef
centralize functions in parcoords helpers
archmoj c4a7867
move function outside main block
archmoj 8b88690
refactor parcoords - rename dd > e
archmoj 643ba30
reduce number of passing argumnets to parcoords
archmoj 5c5873d
add unselected lines color to constants
archmoj e79af84
parcoords refactor - rename glLayers
archmoj 4e3452b
make parcoords pick layer totally invisible
archmoj 75f692d
refactor parcoords - init with new Array and use set instead of push
archmoj 11b9434
mock separated linear axes for every dimension
archmoj 9e73c27
ticktext is now set for each parcoords dimension
archmoj a80bf49
implement cartesian axis for parcoords and change parcoords tickforma…
archmoj 97f61b6
add noCI tags for two more parcoords tests
archmoj dea5317
Merge branch 'master' into refactor-parcoords-bug-fixes-labelangle-side
etpinard c8dedcb
coerce range then create axis
archmoj 2228339
make parcoords + uirevision test pass on CI
etpinard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this look like for multi-line labels?
Cartesian labels have this:
plotly.js/src/plots/cartesian/axes.js
Lines 2482 to 2489 in 0690162
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See example https://rreusser.github.io/plotly-mock-viewer/#bar_multiline_labels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the moment the labels are positioned using the first line.
This is pretty cool! I may give that a try on this PR.