Skip to content

Funnelarea traces #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
May 22, 2019
Merged

Funnelarea traces #3876

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
d77474e
add funnelarea to lib components plot api etc
archmoj May 17, 2019
2d090d1
refactor other traces to reuse code in funnelarea
archmoj May 17, 2019
7b0e602
add funnelarea trace code
archmoj May 17, 2019
1b8caed
add funnelarea jasmine and image tests
archmoj May 17, 2019
32b7b0b
correct groupscale in various dim ratios
archmoj May 18, 2019
68bebc2
Merge branch 'master' into funnelarea-traces
etpinard May 20, 2019
7c3369b
rm 'i' & 'v' from funnelarea event data
etpinard May 20, 2019
abc3b39
revise hiddenlabels coerce - rm hiddenLabels unused category - rm _ha…
archmoj May 20, 2019
316aff9
more explicit funnelarea marker line color - dont inherit from sunburst
archmoj May 20, 2019
7f2dc2a
drop round stroke line join
archmoj May 20, 2019
7e6b9ae
drop quadrants and move func from funnelarea plot - add todo comment …
archmoj May 20, 2019
8bd1875
default funnelarea textinfo to percent not value
archmoj May 21, 2019
fa5b273
move convexPolygonArea to funnelarea_test - add another set of tests …
archmoj May 21, 2019
38b474d
revise funnelarea title attribute - drop support for old API
archmoj May 21, 2019
de8b517
add mock light and dark colorways for pie and funnelarea
archmoj May 21, 2019
a6a6d62
drop sort from one jasmine mock
archmoj May 21, 2019
42ca38e
moduleHasUnSelected > moduleHasUnselected
archmoj May 21, 2019
32c96d2
no need to outsidetextfont attribute in funnelarea
archmoj May 21, 2019
2ad1843
fixup name of funnelarea mock used in mock list
etpinard May 21, 2019
8af4d12
add textposition inside none - change pie title and textposition edit…
archmoj May 21, 2019
4711c5c
Merge branch 'funnelarea-traces' into funnelarea-traces_dev
archmoj May 21, 2019
a9625b6
drop funnelarea sort - auto sort when funnelarea is aggregated - fixu…
archmoj May 21, 2019
1426be7
Merge branch 'master' into funnelarea-traces
etpinard May 21, 2019
79415cd
use trace._meta for funnelarea title.text
etpinard May 21, 2019
e227763
remove outsudetext from funnelarea mock
archmoj May 21, 2019
04b14a8
clear TODO comment for hiddenlabels role
archmoj May 21, 2019
4d89d1d
apply domain width and height with aspectratio
archmoj May 21, 2019
23bc199
add delay between sort-by-value tests
etpinard May 21, 2019
dd673a2
add test for pie title.position restyle calls
etpinard May 21, 2019
6673fac
:hocho: "TODO: test" for attrs that already have sufficient coverage
etpinard May 21, 2019
c64fe84
drop @flaky on @noCI test
etpinard May 21, 2019
77f1c59
drop @noCI on funnel & waterfall select tests
etpinard May 21, 2019
28b2f14
improve funnelarea scalegroup
archmoj May 22, 2019
c42a899
add shapes around domain boxes in funnelarea mocks
archmoj May 22, 2019
84b0dd1
flip processing aspectratio
archmoj May 22, 2019
08a1f7b
remove unused mock
archmoj May 22, 2019
b8b3d94
fit r using trace.aspectratio when having non scalegroup
archmoj May 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/jasmine/tests/calcdata_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ var BADNUM = require('@src/constants/numerical').BADNUM;
var createGraphDiv = require('../assets/create_graph_div');
var destroyGraphDiv = require('../assets/destroy_graph_div');
var failTest = require('../assets/fail_test');
var delay = require('../assets/delay');
var Lib = require('@src/lib');

describe('calculated data and points', function() {
Expand Down Expand Up @@ -985,6 +986,7 @@ describe('calculated data and points', function() {
expect(gd._fullLayout[trace.type === 'splom' ? 'xaxis' : axName]._categories).toEqual(finalOrder, 'wrong order');
}
})
.then(delay(100))
.catch(failTest)
.then(done);
}
Expand Down