Skip to content

Reorganise gl tests for less flakiness #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 13, 2019
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:10.9.0-browsers
parallelism: 2
parallelism: 3
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
'use strict';

var Plotly = require('@lib/index');
var Lib = require('@src/lib');
var d3 = require('d3');
Expand Down Expand Up @@ -197,25 +195,25 @@ describe('contourgl plots', function() {
makePlot(gd, mockCopy, done);
});

it('render without raising an error (coloring: "lines")', function(done) {
it('@gl render without raising an error (coloring: "lines")', function(done) {
var mock = Lib.extendDeep({}, plotDataElliptical(0));
mock.data[0].contours.coloring = 'lines'; // 'fill' is the default
makePlot(gd, mock, done);
});

it('render smooth, regular ellipses without raising an error (coloring: "fill")', function(done) {
it('@gl render smooth, regular ellipses without raising an error (coloring: "fill")', function(done) {
var mock = plotDataElliptical(0);
makePlot(gd, mock, done);
});

it('render ellipses with added noise without raising an error (coloring: "fill")', function(done) {
it('@gl render ellipses with added noise without raising an error (coloring: "fill")', function(done) {
var mock = plotDataElliptical(0.5);
mock.data[0].contours.coloring = 'fill'; // 'fill' is the default
mock.data[0].line = {smoothing: 0};
makePlot(gd, mock, done);
});

it('should update properly', function(done) {
it('@gl should update properly', function(done) {
var mock = plotDataElliptical(0);
var scene2d;

Expand Down
105 changes: 0 additions & 105 deletions test/jasmine/tests/gl2d_date_axis_render_test.js

This file was deleted.

Loading