Skip to content

Fixup jasmine2 to have more consistent CI runs #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 10, 2019

Recently the Jasmine2 container started to constantly failling on the CircleCI. It is also take a long time to fail i.e. about 15-20min.
This PR rearranged some of the tests in the gl2d_double_click_test simply by moving shared functions to the top, avoid nested describe blocks.
A new flag titled dbgl is added for a new container to isolate flaky gl tests.
Parallelism of test-jasmine2 increased from 2 to 3 so that the tests complete around the same time i.e. close to 5 min.
Finally the shard limit reduced to 1 in order to help reduce the chance of possible side effects of running one test on the other.

@plotly/plotly_js

@etpinard
Copy link
Contributor

Thanks for taking a look into this @archmoj

You're right that test-jasmine2 has been very bad lately (after since we merged #3810)

Now, I can't say I'm a fan of this solution. I don't think we should be adding another container (that has a cost 💰 you know) and I don't think we should be adding another @tag (which has a maintenance cost).

Here are some ideas:

  • Have you tried splitting up the @gl test into more _test.js files?
  • There must be something in our @gl that's causing the flakiness? We should try:
    • Adding longer delays between drag commands
    • Adding delays between each it - to allow the container to (hopefully) slow down its CPU usage

@archmoj
Copy link
Contributor Author

archmoj commented May 10, 2019

  • Have you tried splitting up the @gl test into more _test.js files?

It is a very good idea. Namely the gl2d_double_click_test.js.

@archmoj
Copy link
Contributor Author

archmoj commented May 13, 2019

Closing in the favour of #3859.

@archmoj archmoj closed this May 13, 2019
@archmoj archmoj deleted the fix-jasmine2 branch May 22, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants