Plotly.update replot fixes #3825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... during Plotly.update. Clearing gd.data lead to an erroneous
makePlotFramework call which lead to modebar buttons not displaying
(and potentially other bugs)
etpinard
commented
May 1, 2019
| // clear existing data/layout on gd | ||
| // so that Plotly.plot doesn't try to extend them | ||
| gd.data = undefined; | ||
| gd.layout = undefined; |
There was a problem hiding this comment.
N.B. This block was added in 9bad608 - with proper test coverage.
|
Codepen after the fix: https://codepen.io/antoinerg/pen/YbyevG Looks good to me 💃 |
|
I know the issue is closed, but it happens the same when using restyle method, which can be seen in the demos online (https://plotly.com/javascript/custom-buttons/). I was wondering if that can also be fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3824
Plotly.updatecalls likethat lead to restyle flag
fullReplot:trueand relayout flaglayoutReplot:trueerroneously resulted in amakePlotFrameworkcall, which (among other things) cleared the modebar container (added in #3589).In brief,
makePlotFrameworkon "empty" graph divs, I suspect otherPlotly.updatebugs went undetected because of this.cc @plotly/plotly_js I'll ask @antoinerg to review this thing. Thanks!