fixup waterfall connectors on date axes #3791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Apr 18, 2019
etpinard
reviewed
Apr 18, 2019
| @@ -60,11 +60,6 @@ function plotConnectors(gd, plotinfo, cdModule, traceLayer) { | |||
| var x2, y2; | |||
| var x3, y3; | |||
|
|
|||
| var delta = 0; | |||
| if(i + 1 < len && Array.isArray(trace.offset)) { | |||
| delta -= trace.offset[i + 1] - trace.offset[i]; | |||
There was a problem hiding this comment.
Hmm. Where is offset taken in consideration? Do we have a mock with arrayOk trace.offset settings?
There was a problem hiding this comment.
Yes we have: https://github.com/plotly/plotly.js/blob/master/test/image/mocks/waterfall_custom.json
Also here is a codepen using this branch.
|
Nicely done 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3785.
This is similar to the way connectors would be handled in the
funneltrace.codepen After.
@plotly/plotly_js
cc: @nicolaskruchten