Skip to content

exposing pie insert text function #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 17, 2019

This PR refactors and exposes pie insert-text function which appear to be useful in adding textinfo feature for waterfall & funnel in the next release.
See #3777, #3504 and #3504 (comment).

@plotly/plotly_js

@etpinard
Copy link
Contributor

Hmm. I'm not this is worth pursuing. Here's a couple reasons:

  • the flags for bar and waterfall will be different, so as is we can't just ♻️ insideText
  • I'm not a fan of computing the full on-graph text content in calc, I would prefer having this in plot like for sunburst traces.

@archmoj
Copy link
Contributor Author

archmoj commented Apr 17, 2019

Great! Closing in the favour of having this in plot.

@archmoj archmoj closed this Apr 17, 2019
@archmoj archmoj mentioned this pull request Apr 17, 2019
@etpinard etpinard deleted the expose-pie-insert-text branch April 17, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants