Set enabled:false when filter target array is empty #3766
Conversation
- see #2908 for more info, - this fixes many potential problems downstream
| @@ -138,10 +138,16 @@ exports.supplyDefaults = function(transformIn) { | |||
| var enabled = coerce('enabled'); | |||
|
|
|||
| if(enabled) { | |||
| var target = coerce('target'); | |||
|
|
|||
| if(Lib.isArrayOrTypedArray(target) && target.length === 0) { | |||
There was a problem hiding this comment.
Good call. Thanks for the review!
There was a problem hiding this comment.
@archmoj this turned out to be a bit more of a project than anticipated.
See 3a5a4c2 - which makes things work for all trace types except scattercarpet and in some world-calendar scenario. I'll try to get those two cases fixed before 1.48.0, but in the meantime here's "a good chuck" of the solution.
... after transform _module.calc loop - that way filter transforms that remove all data coordinates don't result in errors - of all the mocks listed in mock_lists.js, only 'scattercarpet' and 'world-cals' still error out (wip)
|
@etpinard you mentioned a possible conflict on |
and the fix is in 84c3606 |
|
Looks very good. |
It is handled as it results in |
Could you please provide a codepen example for that? |
|
Thanks. Now could you please check this one. |
I think so. It's not great, but I think traces with |
|
Excellent. |
closes #2908 - by implementing #2908 (comment)
cc @plotly/plotly_js
before/after example: https://codepen.io/etpinard/pen/wYdppB / https://codepen.io/etpinard/pen/WWOVBV