Skip to content

Clean CI run of gl hovers #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Clean CI run of gl hovers #3661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions test/jasmine/tests/cone_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,12 +266,12 @@ describe('Test cone interactions', function() {

function _hover() {
mouseEvent('mouseover', 200, 200);
return delay(20)();
}

Plotly.plot(gd, fig)
.then(delay(20))
.then(_hover)
.then(delay(20))
.then(function() {
assertHoverLabelContent({
nums: ['x: 2', 'y: 2', 'z: 2', 'norm: 3.00'].join('\n')
Expand All @@ -281,6 +281,7 @@ describe('Test cone interactions', function() {
})
.then(delay(20))
.then(_hover)
.then(delay(20))
.then(function() {
assertHoverLabelContent({
nums: ['u: 0', 'v: 3', 'w: 0'].join('\n')
Expand All @@ -302,6 +303,7 @@ describe('Test cone interactions', function() {
})
.then(delay(20))
.then(_hover)
.then(delay(20))
.then(function() {
assertHoverLabelContent({
name: 'trace 0',
Expand All @@ -317,6 +319,7 @@ describe('Test cone interactions', function() {
})
.then(delay(20))
.then(_hover)
.then(delay(20))
.then(function() {
assertHoverLabelContent({
name: 'LOOKOUT',
Expand All @@ -330,7 +333,6 @@ describe('Test cone interactions', function() {
it('@gl should display hover labels (multi-trace case)', function(done) {
function _hover() {
mouseEvent('mouseover', 282, 240);
return delay(20)();
}

Plotly.plot(gd, [{
Expand Down Expand Up @@ -359,6 +361,7 @@ describe('Test cone interactions', function() {
})
.then(delay(20))
.then(_hover)
.then(delay(20))
.then(function() {
assertHoverLabelContent({
nums: ['x: 1', 'y: 1', 'z: 1', 'norm: 1.41'].join('\n'),
Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/tests/gl2d_click_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ describe('Test hover and click interactions', function() {
afterEach(function(done) {
Plotly.purge(gd);
destroyGraphDiv();
setTimeout(done, 1000);
setTimeout(done, 1500);
});

it('@gl should output correct event data for scattergl', function(done) {
Expand Down
2 changes: 2 additions & 0 deletions test/jasmine/tests/gl2d_pointcloud_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ describe('pointcloud traces', function() {
.then(function() {
_assertRange('base', [-0.548, 9.548], [-1.415, 10.415]);
})
.then(delay(40))
.then(function() { _drag([200, 200], [350, 350]); })
.then(delay(40))
.then(function() {
Expand All @@ -247,6 +248,7 @@ describe('pointcloud traces', function() {
.then(function() {
return Plotly.relayout(gd, 'dragmode', 'pan');
})
.then(delay(40))
.then(function() { _drag([200, 200], [350, 350]); })
.then(delay(40))
.then(function() {
Expand Down
Loading