gl2d fixes #3647
Merged
gl2d fixes #3647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 💃 I noticed two more issues with |
archmoj
reviewed
Mar 18, 2019
There was a problem hiding this comment.
Great fix.
I also tested it with paper and plot color using this codepen.
@etpinard Would you be interested in adding a jasmine test?
archmoj
reviewed
Mar 19, 2019
|
I decided to go ahead and fix #3648 in this PR -> https://codepen.io/etpinard/pen/WmgNYx?editors=111 |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2436 and #3624 (about time 😓 ). Both bugs were introduced in #2238
cc @plotly/plotly_js try scrolling and zoombox dragging on this thing: https://codepen.io/etpinard/pen/mojEWY?editors=111
note: double-click interactions have never been implemented on gl2d subplots