Adding third container for jasmine tests to avoid flaky fails #3599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tried re-running the tests a few times to see if it actually helps? |
Good call. It quickly passed the very first time; but then I see it may not pass. |
etpinard
reviewed
Mar 4, 2019
.circleci/test.sh
Outdated
| SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=flaky)) | ||
|
|
||
| for s in ${SHARDS[@]}; do | ||
| retry npm run test-jasmine -- --tags=flaky --skip-tags=noCI |
There was a problem hiding this comment.
This line should be:
retry npm run test-jasmine -- "$s" --tags=flaky --skip-tags=noCI
|
Any updates on this thing? Even if the tests in |
|
Yes. I think it is ready to go. |
|
💃 |
|
Looks good to me 💃 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3587.
@plotly/plotly_js