Code

Improve camera init #3585

Code

Merged

archmoj merged 16 commits intomasterplotly/plotly.js:masterfrom

fix3576-no-rotate-camera-before-modebarplotly/plotly.js:fix3576-no-rotate-camera-before-modebarCopy head branch name to clipboard

Mar 20, 2019

Commits

Commits on Feb 27, 2019

• fix issue 3576 disable camera mouse listener before scene is complete

  archmoj

  committed
  54b1ca1

  Copy full SHA for 54b1ca1

• enable mouse listener when the scene is complete and improved jasmine test - also avoid return in updateFx to ensure dragmode and hovermode stay on the same ground

  archmoj

  committed
  bb252af

  Copy full SHA for bb252af

• improved the test

  archmoj

  committed
  5b8406a

  Copy full SHA for 5b8406a

• added a getter and setter

  archmoj

  committed
  c759396

  Copy full SHA for c759396

• fixed camera init to avoid multiple calls to create camera and resuse the identical camera object in creating gl3d scene

  archmoj

  committed
  66da760

  Copy full SHA for 66da760

• fix gl-plot3d link now use ortho attribute when passing camera object in

  archmoj

  committed
  e48c820

  Copy full SHA for e48c820

Commits on Feb 28, 2019

• improved gl-plot3d scene and camera modules to fixed issue 3576 - lock jasmine test

  archmoj

  committed
  6bd58c9

  Copy full SHA for 6bd58c9

• added noCI flag for the jasmine test

  archmoj

  committed
  a200e78

  Copy full SHA for a200e78

Commits on Mar 5, 2019

• Merge branch 'master' into fix3576-no-rotate-camera-before-modebar

  archmoj

  committed
  09a40af

  Copy full SHA for 09a40af

Commits on Mar 6, 2019

• Merge branch 'master' into fix3576-no-rotate-camera-before-modebar

  archmoj

  committed
  e57631f

  Copy full SHA for e57631f

Commits on Mar 7, 2019

• was able to remove noci flag from some of gl3d jasmine tests

  archmoj

  committed
  4b035d6

  Copy full SHA for 4b035d6

• gl3d jasmine tests run on CI

  archmoj

  committed
  e3ec0e4

  Copy full SHA for e3ec0e4

Commits on Mar 8, 2019

• fixed syntax

  archmoj

  committed
  98b28ac

  Copy full SHA for 98b28ac

Commits on Mar 20, 2019

• resolved conflicts in gl-plot3d

  archmoj

  committed
  25b78ed

  Copy full SHA for 25b78ed

• Merge branch 'master' into fix3576-no-rotate-camera-before-modebar

  archmoj

  authored
  e938c40

  Copy full SHA for e938c40

• add the missing gl tag on one test and bump gl-plot3d 2.2.0

  archmoj

  committed
  6f0330b

  Copy full SHA for 6f0330b