Fix annotations SVG errors on trace-less subplots #3534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... which happens to be the first time it's called
when annotations are present on autoranged axes on
subplots w/o visible traces. This is important to avoid
`transform:rotate(NaN)` errors as annotations require ax._offset
to first-draw text to compute its bounds.
- this is an unreported bug, that the new strict-d3 logic uncovered.
|
Good fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3526 - which was slightly misreported, this bug has nothing to do with heatmaps. All cartesian autoranged subplots w/o a single
visible:truetrace were affected.cc @plotly/plotly_js looking a for a quick review. I'll like to include this in tomorrow's
v1.44.4. Thanks!