Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waterfall charts #3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waterfall charts #3531
Changes from 1 commit
8f89564
5678653
cfe8eb2
dbc98b5
acc3640
9537ee8
6be0a4a
d6a69f2
34b6a0a
aa58571
6a4666a
3fb3597
dc1b420
f8507ce
a875ac7
69956a0
82dfd18
87ad17c
b0fdced
4c4c8e5
c052205
fb28e30
ea4863f
af60c1f
1827ee6
89e66bb
4383a71
2454e6c
3533448
cd16944
f9b36cb
3386803
d1c8c48
cd81dcd
e7602e2
d1bbae6
59ee151
d8d54cd
c1ed50f
346c637
fed3c97
aa8abe4
a05352f
20d1cbc
692c6d4
c0b1017
9533558
2480892
f3f7d84
7e41079
84e3a27
00070ba
dcab107
d52116b
6d37db9
fb0d7a9
9e941ba
2a25753
1825027
4a044e4
c53bcce
3b984ff
6b3eeab
ce0a56a
412bf9d
a55777f
dee39dc
a138ebd
7019a12
8bbc863
b6fdaed
cb8f1ec
1447b40
4eb5daf
f3a071e
1721ab7
7655664
1d275f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have two
marker
containers for waterfall traces: one for increasing bars and one for decreasing bars, similar to howohlc
andcandlestick
do it.plotly.js/src/traces/ohlc/attributes.js
Lines 89 to 91 in 02e51d8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These attribute containers don't appear to be implemented. No big deal, but please remove them from the attribute declaration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we should keep
[un]selected.marker.opacity