Skip to content

Bug fix - enabling transparent webgl draws for scatter3d trace when colors are transparent #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Bug fix - enabling transparent webgl draws for scatter3d trace when colors are transparent #3495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
718f086
bug fix issue 3492 enable transparent draw when having transparent co…
archmoj Jan 29, 2019
432fb56
added a baseline to lock bug issue 3492
archmoj Jan 29, 2019
ed41e8a
one new baseline change
archmoj Jan 29, 2019
164a3a4
correct baseline
archmoj Jan 30, 2019
862d51c
fixup
archmoj Jan 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@
"font-atlas-sdf": "^1.3.3",
"gl-cone3d": "^1.2.2",
"gl-contour2d": "^1.1.5",
"gl-error3d": "^1.0.12",
"gl-error3d": "git://github.com/gl-vis/gl-error3d.git#9835d7b63d64e5de2b24d9e7f810452151af9a58",
"gl-heatmap2d": "^1.0.5",
"gl-line3d": "^1.1.9",
"gl-line3d": "git://github.com/gl-vis/gl-line3d.git#d2ea962c00e9f592ec0506ba33d14c7d25b85659",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/gl-vis/gl-line3d/compare/fix3492-enable-opacity-by-alpha

"gl-mat4": "^1.2.0",
"gl-mesh3d": "^2.0.7",
"gl-plot2d": "^1.4.2",
"gl-plot3d": "^1.6.3",
"gl-pointcloud2d": "^1.0.2",
"gl-scatter3d": "^1.1.5",
"gl-scatter3d": "git://github.com/gl-vis/gl-scatter3d.git#afc69258bef5a458e83b7d031ccfc6ada8e098fb",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/gl-vis/gl-scatter3d/compare/fix3492-enable-opacity-by-alpha

"gl-select-box": "^1.0.3",
"gl-spikes2d": "^1.0.2",
"gl-streamtube3d": "^1.1.2",
Expand Down
Binary file added .../image/baselines/gl3d_scatter3d_line3d_error3d_enable-alpha-with-rgba-color.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/image/baselines/gl3d_scatter3d_line3d_error3d_transparent-with-zero-alpha.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
43 changes: 43 additions & 0 deletions test/image/mocks/gl3d_scatter3d_line3d_error3d_enable-alpha-with-rgba-color.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
{
"data": [
{
"x": [0, 1, 2, 3, 4],
"y": [0, 1, 2, 3, 4],
"z": [0,-1,-2,-3,-4],
"mode": "markers+lines",
"marker": {
"size": 50,
"color": ["rgb(0, 255, 0, 1.0)", "rgb(255, 0, 0, 1.0)", "rgb(255, 0, 0, 0.2)", "rgb(255, 0, 0, 1.0)", "rgb(0, 0, 255, 1.0)"]
},
"line": {
"width": 50,
"color": ["rgb(0, 255, 0, 1.0)", "rgb(255, 0, 0, 1.0)", "rgb(255, 0, 0, 0.2)", "rgb(255, 0, 0, 1.0)", "rgb(0, 0, 255, 1.0)"]
},
"error_z": {
"type": "sqrt",
"line": { "thickness": 10 },
"color": "rgb(255, 127, 0, 0.75)"
},
"error_x": {
"type": "sqrt"
},
"error_y": {
"type": "sqrt"
},
"type": "scatter3d"
}
],
"layout": {
"title": {
"text": "Should draw transparent scatter3d markers and lines<br>when having transparent rgba color"
},
"width": 600,
"height": 600,
"scene": {
"xaxis": { "nticks": 12 },
"yaxis": { "nticks": 12 },
"zaxis": { "nticks": 12 }
}
}

}