responsive tests: check size of DOM elements with getBoundingClientRect() #3484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinerg
commented
Jan 25, 2019
| @@ -553,7 +553,7 @@ describe('config argument', function() { | |||
|
|
|||
| describe('responsive figure', function() { | |||
| var gd; | |||
| var data = [{x: [1, 2, 3, 4], y: [5, 10, 2, 8]}]; | |||
| var data = [{type: 'scatter', x: [1, 2, 3, 4], y: [5, 10, 2, 8]}]; | |||
There was a problem hiding this comment.
It is scatter by default, but it is clearer if we make it explicit.
antoinerg
commented
Jan 25, 2019
| var mainSvgs = document.getElementsByClassName('main-svg'); | ||
| checkElementsSize(mainSvgs, elWidth / 2, elHeight / 2); | ||
|
|
||
| var canvases = document.getElementsByTagName('canvas'); |
There was a problem hiding this comment.
Checking the size of the canvas elements sandwiched between the SVG elements is also very important.
|
@antoinerg , maybe use |
|
💃 thanks! Next time though:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes for more robust tests since a
styleattribute can override thewidthandheightattribute of a DOM element. We now check for both to be safe.@plotly/core-contributors