-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Mesh3d lighting fix #3415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Mesh3d lighting fix #3415
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
cf85a16
test mesh3d with medium precision
archmoj 70b2d6c
using the code similar to surface lighting
archmoj 012830b
unify mesh3d lighting with surface
archmoj 7781ebc
improved new mock
archmoj be0d51d
baseline showing both mesh3d and surface traces use identical light p…
archmoj e6e1db4
fixed gl-mesh3d lighting
archmoj e22df6d
original baselines back
archmoj 70000b2
fix face direction
archmoj fe1cdee
new baselines
archmoj 0e1af3b
Revert "new baselines"
archmoj d742ccc
fixed face directions
archmoj 5c71200
reversed gl-mesh3d face order
archmoj 86f6bdc
new baselines improved version
archmoj cc2f294
bump gl-mesh3d 2.0.5
archmoj d3ece95
Merge branch 'master' into fix3353-light-reversed-ranges
etpinard 9d70ef0
updated one new baseline
archmoj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-1.72 KB
(98%)
...aselines/gl3d_mesh3d_surface3d_scatter3d_line3d_error3d_log_reversed_ranges.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
{ | ||
"data": [ | ||
{ | ||
"x": [0, 0, 0, 1, 1, 1, 2, 2, 2], | ||
"y": [100, 101, 102, 100, 101, 102, 100, 101, 102], | ||
"z": [1.5, 1.5, 1.5, 1.5, 2.5, 3.5, 1.5, 3.5, 5.5], | ||
"type": "mesh3d", | ||
"color": "grey", | ||
"lighting": { "ambient": 0.5, "diffuse": 0.5, "specular": 0.5, "roughness": 0.5, "fresnel": 0.5 }, | ||
"lightposition": { "x": 0, "y": 2000, "z": 1000 } | ||
}, | ||
{ | ||
"x": [0, 0, 0, 1, 1, 1, 2, 2, 2], | ||
"y": [100, 99, 98, 100, 99, 98, 100, 99, 98], | ||
"z": [1.5, 1.5, 1.5, 1.5, 2.5, 3.5, 1.5, 3.5, 5.5], | ||
"type": "mesh3d", | ||
"color": "grey", | ||
"lighting": { "ambient": 0.5, "diffuse": 0.5, "specular": 0.5, "roughness": 0.5, "fresnel": 0.5 }, | ||
"lightposition": { "x": 0, "y": 2000, "z": 1000 } | ||
}, | ||
{ | ||
"x": [0, 0, 0, -1, -1, -1, -2, -2, -2], | ||
"y": [100, 99, 98, 100, 99, 98, 100, 99, 98], | ||
"z": [1.5, 1.5, 1.5, 1.5, 2.5, 3.5, 1.5, 3.5, 5.5], | ||
"type": "mesh3d", | ||
"color": "grey", | ||
"lighting": { "ambient": 0.5, "diffuse": 0.5, "specular": 0.5, "roughness": 0.5, "fresnel": 0.5 }, | ||
"lightposition": { "x": 0, "y": 2000, "z": 1000 } | ||
}, | ||
{ | ||
"x": [0, 0, 0, -1, -1, -1, -2, -2, -2], | ||
"y": [100, 101, 102, 100, 101, 102, 100, 101, 102], | ||
"z": [1.5, 1.5, 1.5, 1.5, 2.5, 3.5, 1.5, 3.5, 5.5], | ||
"type": "mesh3d", | ||
"color": "grey", | ||
"lighting": { "ambient": 0.5, "diffuse": 0.5, "specular": 0.5, "roughness": 0.5, "fresnel": 0.5 }, | ||
"lightposition": { "x": 0, "y": 2000, "z": 1000 } | ||
}, | ||
{ | ||
"x": [-2, -1, 0, 1, 2], | ||
"y": [98, 99, 100, 101, 102], | ||
"z": [ | ||
[4, 2, 0, 2, 4], | ||
[2, 1, 0, 1, 2], | ||
[0, 0, 0, 0, 0], | ||
[2, 1, 0, 1, 2], | ||
[4, 2, 0, 2, 4] | ||
], | ||
"type": "surface", | ||
"colorscale": [[0, "grey"], [1, "grey"]], | ||
"showscale": false, | ||
"lighting": { "ambient": 0.5, "diffuse": 0.5, "specular": 0.5, "roughness": 0.5, "fresnel": 0.5 }, | ||
"lightposition": { "x": 0, "y": 2000, "z": 1000 } | ||
} | ||
], | ||
"layout": { | ||
"height": 800, | ||
"width": 800, | ||
"title": { | ||
"text": "Mesh3d and surface lighting" | ||
}, | ||
"scene": { | ||
"xaxis": { | ||
}, | ||
"yaxis": { | ||
}, | ||
"zaxis": { | ||
}, | ||
"camera": { | ||
"eye": { | ||
"x": 2.0, | ||
"y": -1.5, | ||
"z": 0.5 | ||
} | ||
} | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/gl-vis/gl-mesh3d/compare/3353-light-reversed-ranges