Skip to content

Replacing 2018 Copyright years with 2019 #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2019
Merged

Replacing 2018 Copyright years with 2019 #3381

merged 2 commits into from
Jan 1, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Dec 31, 2018

Failed the syntax test for the moment; but that may be passed in 2019!
Happy new year @plotly/plotly_js

@archmoj
Copy link
Contributor Author

archmoj commented Jan 1, 2019

OK. The tests are passed now.
I move forward and merge this thing!

@archmoj archmoj merged commit fc4511c into master Jan 1, 2019
@archmoj archmoj deleted the new-year-2019 branch January 1, 2019 01:39
@etpinard
Copy link
Contributor

etpinard commented Jan 2, 2019

Thanks! I hope you didn't do this by hand and used

(plotly.js) $ node tasks/header.js

@archmoj
Copy link
Contributor Author

archmoj commented Jan 2, 2019

Lovely script! Though I didn't used that for this year.
Should we also change the copyright on the files on the dist folder?
Running the script on master only show me that difference.

@etpinard
Copy link
Contributor

etpinard commented Jan 2, 2019

Should we also change the copyright on the files on the dist folder?

No need. We'll do that during the next release 1.43.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants