Skip to content

Add postshrinkwrap step to replace http:// -> https:// #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2018

Conversation

etpinard
Copy link
Contributor

More info:

so that

git checkout master
npm i

doesn't lead to

image

ever again!

cc @plotly/plotly_js

@@ -153,6 +154,7 @@
"prepend-file": "^1.3.1",
"prettysize": "^2.0.0",
"read-last-lines": "^1.6.0",
"replace": "^1.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting; the version 1.0.1 was published a week ago.

@archmoj
Copy link
Contributor

archmoj commented Dec 25, 2018

Looks like a 💃 to me.
Edit: but please wait! The replace module could perform a lot of interesting things to the source which one may not need. Wondering
could we use a simple replace https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace to have a function that replace the first 'http://' on each line?

@etpinard
Copy link
Contributor Author

etpinard commented Dec 26, 2018

Wondering
could we use a simple replace https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace to have a function that replace the first 'http://' on each line?

77a026b should be bullet-proof now. Thanks!

@archmoj
Copy link
Contributor

archmoj commented Dec 27, 2018

💃

@etpinard etpinard merged commit 112ab61 into master Dec 27, 2018
@etpinard etpinard deleted the replace-http-https branch December 27, 2018 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants